[Bugs] [Bug 1659676] New: Memory leak: dict_t leak in rda_opendir

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1659676

            Bug ID: 1659676
           Summary: Memory leak: dict_t leak in rda_opendir
           Product: GlusterFS
           Version: 5
            Status: NEW
         Component: core
          Severity: high
          Priority: high
          Assignee: bugs at gluster.org
          Reporter: nbalacha at redhat.com
                CC: bugs at gluster.org, y.zhao at nokia.com
        Depends On: 1659432
            Blocks: 1659439
  Target Milestone: ---
    Classification: Community



+++ This bug was initially created as a clone of Bug #1659432 +++

Description of problem:


rda_opendir creates and leaks a dict_t xdata_from_req

Version-Release number of selected component (if applicable):


How reproducible:

Consistently.


Steps to Reproduce:
1. Create a 1 brick volume and fuse mount it.
2. Create a directory mydir in the volume root.
3. Compile the following test code and run it on the volume in a loop, while
checking RES in top output for the fuse mount process.


<code>

#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
#include <dirent.h>


int main (int argc, char *argv[])
{
        DIR *fd = NULL; 
        char *name = NULL; 

        if (argc != 2) { 
                printf ("Usage: %s <dirpath>\n", argv[0]);
                exit (1);
        }
        name = argv[1];
        fd = opendir(name);

        if (!fd) { 
                exit (1);
        }

        closedir (fd);
}

</code>


cd /mnt/gluster-mnt
Run
while (true); do ./a.out ./mydir; done



Actual results:
Memory use rises constantly.

Expected results:
Memory usage should stay constant after the initial run.

Additional info:

--- Additional comment from Nithya Balachandran on 2018-12-14 11:20:16 UTC ---

https://review.gluster.org/#/c/glusterfs/+/21859/

--- Additional comment from Worker Ant on 2018-12-14 11:40:17 UTC ---

REVIEW: https://review.gluster.org/21859 (performance/rda:  Fixed dict_t memory
leak) posted (#1) for review on master by N Balachandran

--- Additional comment from Worker Ant on 2018-12-14 11:40:57 UTC ---

REVIEW: https://review.gluster.org/21859 (performance/rda:  Fixed dict_t memory
leak) posted (#1) for review on master by N Balachandran

--- Additional comment from Worker Ant on 2018-12-14 15:22:54 UTC ---

REVIEW: https://review.gluster.org/21859 (performance/rda:  Fixed dict_t memory
leak) posted (#2) for review on master by Xavi Hernandez

--- Additional comment from Yan on 2018-12-14 22:48:32 UTC ---

The fuse RSS memory increase issue is similar to below one. Could you confirm? 

https://bugzilla.redhat.com/show_bug.cgi?id=1623107


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1659432
[Bug 1659432] Memory leak: dict_t leak in rda_opendir
https://bugzilla.redhat.com/show_bug.cgi?id=1659439
[Bug 1659439] Memory leak: dict_t leak in rda_opendir
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.