[automated-testing] Usage of Function name in ib_utils

[Nigel Babu]

I'm okay with any of the following

1. open_firewall_for_service, close_firewall_for_service
2. open_port, close_port
3. remove_service_from_firewall, add_service_to_firewall

Please pick one and send a review request fixing all the current code
references.


On Tue, Jun 5, 2018 at 3:48 PM, Vijay Bhaskar Reddy Avuthu <
vavuthu at redhat.com> wrote:

> Hi All,
>
> It looks like there is a confusion of using function name for firewall
> library.
>
> library : *glustolibs-gluster/glustolibs/gluster/lib_utils.py *
>
> 1) def *open_firewall*(nodes, firewall_service, permanent=False): --->
> merged one
>
> since above function will disable the services, In my opinion its better
> to change the name to disable_firewall or remove_services_from_firewall
>
>
> 2) def *enable_firewall*(nodes, firewall_service, permanent=False): ---->
> https://review.gluster.org/#/c/19481/7
>
>
> Above function will enable the services, its better to have the same name
> enable_firewall or add_services_to_firwall
>
>
> Any thoughts or suggestions ?
>
> Regards,
> Vijay A
>
> _______________________________________________
> automated-testing mailing list
> automated-testing at gluster.org
> http://lists.gluster.org/mailman/listinfo/automated-testing
>
>


-- 
nigelb
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/automated-testing/attachments/20180605/3d390dc3/attachment.html>