<div dir="ltr"><div>I'm okay with any of the following</div><div><br></div><div>1. open_firewall_for_service, close_firewall_for_service</div><div>2. open_port, close_port</div><div>3. remove_service_from_firewall, add_service_to_firewall<br></div><div><br></div><div>Please pick one and send a review request fixing all the current code references.<br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 5, 2018 at 3:48 PM, Vijay Bhaskar Reddy Avuthu <span dir="ltr"><<a href="mailto:vavuthu@redhat.com" target="_blank">vavuthu@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi All,<br><br>It looks like there is a confusion of using function name for firewall library.<br><br>library : <b>glustolibs-gluster/glustolibs/<wbr>gluster/lib_utils.py </b><br><br>1) def <b>open_firewall</b>(nodes, firewall_service, permanent=False): ---> merged one<br><br>since above function will disable the services, In my opinion its better to change the name to disable_firewall or remove_services_from_firewall<br> <br><br>2) def <b>enable_firewall</b>(nodes, firewall_service, permanent=False): ----> <a href="https://review.gluster.org/#/c/19481/7" target="_blank">https://review.gluster.org/#/<wbr>c/19481/7</a><br><br><br>Above function will enable the services, its better to have the same name enable_firewall or add_services_to_firwall<br><br><br>Any thoughts or suggestions ?<br><br>Regards,<br>Vijay A<br></div>
<br>______________________________<wbr>_________________<br>
automated-testing mailing list<br>
<a href="mailto:automated-testing@gluster.org">automated-testing@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/automated-testing" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/automated-<wbr>testing</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">nigelb<br></div></div>
</div>