[Gluster-Maintainers] RFC: Suggestions on patches taking more than 10 tries

[Pranith Kumar Karampuri]

On Tue, Oct 31, 2017 at 5:33 PM, Atin Mukherjee <amukherj at redhat.com> wrote:

> Honestly I have been doing this for some time based on the criticality of
> the patches and of course with an agreement with the original author of the
> patches. Another factor we need to consider here about patches where the
> comments were available and haven't been addressed for a significant
> period. We should also need to consider such patches based on their
> importance and refresh them.
>

I do this as well.


>
> On Tue, Oct 31, 2017 at 4:21 PM, Jeff Darcy <jeff at pl.atyp.us> wrote:
>
>>
>>
>>
>> On Tue, Oct 31, 2017, at 01:01 AM, Amar Tumballi wrote:
>>
>> In this case, I suggest maintainers can send a message to author, and
>> send an updated patch with their suggestion (with making sure '--author' is
>> set to original author). This can save both the effort of review, and also
>> heart burn of someone not understanding the comments properly.
>>
>>
>> I would really like it if we could get to the point where maintainers (or
>> others) could feel comfortable updating other contributors' patches,
>> because it really would improve our development velocity.  I've done it
>> very sparingly, usually only for patches that the author seemed to have
>> given up on, because there is a risk of people being offended.  It can feel
>> like someone else is trying to take control of - or even credit for - one's
>> own work.  To avoid this, I think we need to do two things:
>>
>> (1) Thoroughly document how to update someone else's patch while
>> retaining proper credit for their work, and how to accept such an update
>> into one's own local repository.  This addresses the technical/logistical
>> issue.
>>
>> (2) Recognize new contributors as such and automatically (or at least
>> semi-automatically) send them email explaining our expectations and
>> standards for review etiquette - including this, but other things as well.
>> This addresses the cultural issue.
>>
>> _______________________________________________
>> maintainers mailing list
>> maintainers at gluster.org
>> http://lists.gluster.org/mailman/listinfo/maintainers
>>
>>
>
> _______________________________________________
> maintainers mailing list
> maintainers at gluster.org
> http://lists.gluster.org/mailman/listinfo/maintainers
>
>


-- 
Pranith
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/maintainers/attachments/20171031/bb8a2e2b/attachment-0001.html>