<div dir="ltr"><br><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 31, 2017 at 5:33 PM, Atin Mukherjee <span dir="ltr"><<a href="mailto:amukherj@redhat.com" target="_blank">amukherj@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Honestly I have been doing this for some time based on the criticality of the patches and of course with an agreement with the original author of the patches. Another factor we need to consider here about patches where the comments were available and haven't been addressed for a significant period. We should also need to consider such patches based on their importance and refresh them. <br></div></blockquote><div><br></div><div>I do this as well.<br> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Tue, Oct 31, 2017 at 4:21 PM, Jeff Darcy <span dir="ltr"><<a href="mailto:jeff@pl.atyp.us" target="_blank">jeff@pl.atyp.us</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><u></u>
<div><span><div style="font-family:Arial"><br></div>
<div><br></div>
<div><br></div>
<div>On Tue, Oct 31, 2017, at 01:01 AM, Amar Tumballi wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div>In this case, I suggest maintainers can send a message to author, and send an updated patch with their suggestion (with making sure '--author' is set to original author). This can save both the effort of review, and also heart burn of someone not understanding the comments properly. <br></div>
</div>
</blockquote><div style="font-family:Arial"><br></div>
</span><div style="font-family:Arial">I would really like it if we could get to the point where maintainers (or others) could feel comfortable updating other contributors' patches, because it really would improve our development velocity. I've done it very sparingly, usually only for patches that the author seemed to have given up on, because there is a risk of people being offended. It can feel like someone else is trying to take control of - or even credit for - one's own work. To avoid this, I think we need to do two things:<br></div>
<div style="font-family:Arial"><br></div>
<div style="font-family:Arial">(1) Thoroughly document how to update someone else's patch while retaining proper credit for their work, and how to accept such an update into one's own local repository. This addresses the technical/logistical issue.<br></div>
<div style="font-family:Arial"><br></div>
<div style="font-family:Arial">(2) Recognize new contributors as such and automatically (or at least semi-automatically) send them email explaining our expectations and standards for review etiquette - including this, but other things as well. This addresses the cultural issue.</div>
</div>
<br></div></div>______________________________<wbr>_________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org" target="_blank">maintainers@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">http://lists.gluster.org/mailm<wbr>an/listinfo/maintainers</a><br>
<br></blockquote></div><br></div></div></div>
<br>______________________________<wbr>_________________<br>
maintainers mailing list<br>
<a href="mailto:maintainers@gluster.org">maintainers@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/maintainers" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/maintainers</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Pranith<br></div></div>
</div></div></div>