[Gluster-devel] Removing glupy from release 5.7

Niels de Vos ndevos at redhat.com
Fri Jul 5 13:17:09 UTC 2019


On Thu, Jul 04, 2019 at 05:03:53PM +0200, Michael Scherer wrote:
> Le jeudi 04 juillet 2019 à 16:20 +0200, Niels de Vos a écrit :
> > On Wed, Jul 03, 2019 at 04:46:11PM +0200, Michael Scherer wrote:
> > > Le mercredi 03 juillet 2019 à 20:03 +0530, Deepshikha Khandelwal a
> > > écrit :
> > > > Misc, is EPEL got recently installed on the builders?
> > > 
> > > No, it has been there since september 2016. What got changed is
> > > that
> > > python3 wasn't installed before.
> > > 
> > > > Can you please resolve the 'Why EPEL on builders?'. EPEL+python3
> > > > on
> > > > builders seems not a good option to have.
> > > 
> > > 
> > > Python 3 is pulled by 'mock', cf 
> > > 
> https://lists.gluster.org/pipermail/gluster-devel/2019-June/056347.html
> > > 
> > > So sure, I can remove EPEL, but then it will remove mock. Or I can
> > > remove python3, and it will remove mock.
> > > 
> > > But again, the problem is not with the set of installed packages on
> > > the
> > > builder, that's just showing there is a bug.
> > > 
> > > The configure script do pick the latest python version:
> > > https://github.com/gluster/glusterfs/blob/master/configure.ac#L612
> > > 
> > > if there is a python3, it take that, if not, it fall back to
> > > python2. 
> > > 
> > > then, later:
> > > https://github.com/gluster/glusterfs/blob/master/configure.ac#L639
> > > 
> > > it verify the presence of what is required to build.
> > > 
> > > So if there is a runtime version only of python3, it will detect
> > > python3, but not build anything, because the -devel subpackage is
> > > not h
> > > ere. 
> > > 
> > > There is 2 solutions:
> > > - fix that piece of code, so it doesn't just test the presence of
> > > python executable, but do that, and test the presence of headers
> > > before
> > > deciding if we need to build or not glupy.
> > > 
> > > - use PYTHON env var to force python2, and document that it need to
> > > be
> > > done.  
> > 
> > What about option 3:
> > 
> > - install python3-devel in addition to python3
> 
> That's a option, but I think that's a disservice for the users, since
> that's fixing our CI to no longer trigger a corner case, which doesn't
> mean the corner case no longer exist, just that we do not trigger it. 

This is only interesting for building releases/packages, I think. Normal
build environments have -devel packages installed for the components
that are used during the build process. The weird python2-devel and
python3 (without -devel) is definitely a corner case, but not something
people would normally have. And if so, we expect -devel for the python
version that is used, so developers would hopefully just install that on
their build system.

Niels


More information about the Gluster-devel mailing list