[Gluster-devel] Fwd: Clang-format: Update

[Amar Tumballi]

On Thu, Jun 28, 2018 at 5:20 PM, Niels de Vos <ndevos at redhat.com> wrote:

> On Thu, Jun 28, 2018 at 04:52:24PM +0530, Nigel Babu wrote:
> > Hello folks,
> >
> > A while ago we talked about using clang-format for our codebase[1]. We
> > started doing several pieces of this work asynchronously. Here's an
> update
> > on the current state of affairs:
> >
> > * Team agrees on a style and a config file representing the style.
> > This has been happening asynchronously on Github[2]. Amar, Xavi, and Jeff
> > -- Can we close out this discussion and have a config file in 2 weeks? If
> > anyone feels strongly about coding style, please participate in the
> > discussion now.
> >
> > * Commit the coding style guide to codebase and make changes in rfc.sh to
> > use it.
> > Waiting on 1. I can do this once we have the discussion finalized.
> >
> > * gluster-ant commits a single large patch for whole codebase with a
> > standard clang-format style.
> > This is waiting on the first two steps and should be trivial to
> accomplish.
> > I have access to the gluster-ant account and I can make the necessary
> > changes.
>
> Can this be done as one of the last patches before branching the next
> release? A large change like this may make backporting to the maintained
> 3.12 and 4.1 branches more annoying. If it gets changed with a single
> large patch, there is little need to push it through in the middle of a
> release IMHO.
>
>
We discussed a bit about it. Even if we do it at the branch of next
release, it would still be an issue to back port to 4.1 (as it is a
supported release for year).

This improvement would make the review process faster (and at least new
developer experience better), so better to do it earlier than later IMO.


> Thanks,
> Niels
>
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Amar Tumballi (amarts)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20180628/08e6325b/attachment.html>