<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 28, 2018 at 5:20 PM, Niels de Vos <span dir="ltr"><<a href="mailto:ndevos@redhat.com" target="_blank">ndevos@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Jun 28, 2018 at 04:52:24PM +0530, Nigel Babu wrote:<br>
> Hello folks,<br>
> <br>
> A while ago we talked about using clang-format for our codebase[1]. We<br>
> started doing several pieces of this work asynchronously. Here's an update<br>
> on the current state of affairs:<br>
> <br>
> * Team agrees on a style and a config file representing the style.<br>
> This has been happening asynchronously on Github[2]. Amar, Xavi, and Jeff<br>
> -- Can we close out this discussion and have a config file in 2 weeks? If<br>
> anyone feels strongly about coding style, please participate in the<br>
> discussion now.<br>
> <br>
> * Commit the coding style guide to codebase and make changes in rfc.sh to<br>
> use it.<br>
> Waiting on 1. I can do this once we have the discussion finalized.<br>
> <br>
> * gluster-ant commits a single large patch for whole codebase with a<br>
> standard clang-format style.<br>
> This is waiting on the first two steps and should be trivial to accomplish.<br>
> I have access to the gluster-ant account and I can make the necessary<br>
> changes.<br>
<br>
</span>Can this be done as one of the last patches before branching the next<br>
release? A large change like this may make backporting to the maintained<br>
3.12 and 4.1 branches more annoying. If it gets changed with a single<br>
large patch, there is little need to push it through in the middle of a<br>
release IMHO.<br>
<br></blockquote><div><br></div><div>We discussed a bit about it. Even if we do it at the branch of next release, it would still be an issue to back port to 4.1 (as it is a supported release for year).</div><div><br></div><div>This improvement would make the review process faster (and at least new developer experience better), so better to do it earlier than later IMO.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks,<br>
Niels<br>
<br>______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div></div>