[Gluster-devel] Message id's for components

Amar Tumballi atumball at redhat.com
Thu Dec 14 05:08:07 UTC 2017

This one is a good cleanup Xavi!

It is now merged!

On Wed, Dec 13, 2017 at 4:20 AM, Xavi Hernandez <jahernan at redhat.com> wrote:

> Hi,
> I've uploaded a patch [1] to change the way used to reserve a range of
> messages to components and to define message id's inside a component.
> The old method was error prone because adding a new component needed to
> define some macros based on previous macros (in fact there was already an
> invalid definition for a component). The definition of message id's for a
> component also required more than one modification and in some cases it was
> not correctly done.
> The new patch defines the message constants using an enum, which automates
> all assignments, preventing most of the errors. It also defines a couple of
> macros that makes it even easier to create the component ranges and message
> id's.
> Any feedback will be appreciated.
> Regards,
> Xavi
> [1] https://review.gluster.org/19029
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel

Amar Tumballi (amarts)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20171214/30bd13a8/attachment.html>

More information about the Gluster-devel mailing list