<div dir="ltr">This one is a good cleanup Xavi!<div><br></div><div>It is now merged!</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 13, 2017 at 4:20 AM, Xavi Hernandez <span dir="ltr"><<a href="mailto:jahernan@redhat.com" target="_blank">jahernan@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>I've uploaded a patch [1] to change the way used to reserve a range of messages to components and to define message id's inside a component.</div><div><br></div><div>The old method was error prone because adding a new component needed to define some macros based on previous macros (in fact there was already an invalid definition for a component). The definition of message id's for a component also required more than one modification and in some cases it was not correctly done.</div><div><br></div><div>The new patch defines the message constants using an enum, which automates all assignments, preventing most of the errors. It also defines a couple of macros that makes it even easier to create the component ranges and message id's.</div><div><br></div><div>Any feedback will be appreciated.</div><div><br></div><div>Regards,</div><div><br></div><div>Xavi</div><div><br></div><div>[1] <a href="https://review.gluster.org/19029" target="_blank">https://review.gluster.<wbr>org/19029</a></div></div>
<br>______________________________<wbr>_________________<br>
Gluster-devel mailing list<br>
<a href="mailto:Gluster-devel@gluster.org">Gluster-devel@gluster.org</a><br>
<a href="http://lists.gluster.org/mailman/listinfo/gluster-devel" rel="noreferrer" target="_blank">http://lists.gluster.org/<wbr>mailman/listinfo/gluster-devel</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>Amar Tumballi (amarts)<br></div></div></div></div></div>
</div>