[Gluster-devel] Message id's for components

Xavi Hernandez jahernan at redhat.com
Tue Dec 12 22:50:23 UTC 2017


I've uploaded a patch [1] to change the way used to reserve a range of
messages to components and to define message id's inside a component.

The old method was error prone because adding a new component needed to
define some macros based on previous macros (in fact there was already an
invalid definition for a component). The definition of message id's for a
component also required more than one modification and in some cases it was
not correctly done.

The new patch defines the message constants using an enum, which automates
all assignments, preventing most of the errors. It also defines a couple of
macros that makes it even easier to create the component ranges and message

Any feedback will be appreciated.



[1] https://review.gluster.org/19029
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20171212/c457ba4a/attachment.html>

More information about the Gluster-devel mailing list