[Gluster-devel] static analysis updated

[Kaleb S. KEITHLEY]

On 12/19/2016 12:49 PM, Nigel Babu wrote:
> Thank you Kaleb. Shall we start somwhere in terms of automation?
> 
> The cppcheck results look the shortest[1]. If we can commit to fixing all of
> them in the next 1 month, I can kick off a non-voting smoke job. We'll make it
> vote after 1 month. I guess the cli and experimental xlator (and a few more
> xlators, please check log) owners need to confirm that this is something we can
> target to fix. And commit to keeping fixed.

Hi,

It would be great to fix those, but——

IIRC we discussed a two compile before-and-after test, i.e. compile the
tree before and after applying the patch. If the second compile has more
(or different) warnings than the first, then the test scores a fail.

If we do that we don't have to wait (as long) to make it a voting test.

Once we have a voting test, then maintainers have not choice but to keep
things fixed. ;-)


> 
> Thoughts?
> 
> 
> [1]: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-cppcheck/2016-12-19-2bb23136/cppcheck.txt
> 
> 
> On Mon, Dec 19, 2016 at 11:33:16AM -0500, Kaleb S. KEITHLEY wrote:
>> Hi,
>>
>> Nightly runs of static analyzers have been migrated to a new host
>> (inside Red Hat) running Fedora 25. (The old host was running F23.)
>>
>> With that update comes clang-3.8 (from 3.7) and cppcheck-1.75 (from 1.70).
>>
>> Independent of that, coverity was updated from 7.7.0 to 8.6.0.
>>
>> As always the results of coverity scan, clang compile, clang analyzer,
>> and cppcheck are available at
>> https://download.gluster.org/pub/gluster/glusterfs/static-analysis/
>>
>> Longer term plans still include migrating these nightly tasks to the
>> "community cage" and better integration with Gerrit and Jenkins.
>>
>> --
>>
>> Kaleb
> 
> --
> nigelb
> 

-- 

Kaleb

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://www.gluster.org/pipermail/gluster-devel/attachments/20161219/cc8e6dbe/attachment.sig>