[Gluster-devel] good job on fixing heavy hitters in spurious regressions

Atin Mukherjee amukherj at redhat.com
Sat May 9 04:49:09 UTC 2015



On 05/09/2015 01:25 AM, Pranith Kumar Karampuri wrote:
> 
> On 05/08/2015 09:14 AM, Krishnan Parthasarathi wrote:
>>
>> ----- Original Message -----
>>> hi,
>>>          I think we fixed quite a few heavy hitters in the past week and
>>> reasonable number of regression runs are passing which is a good sign.
>>> Most of the new heavy hitters in regression failures seem to be code
>>> problems in quota/afr/ec, not sure about tier.t (Need to get more info
>>> about arbiter.t, read-subvol.t etc). Do you guys have any ideas in
>>> keeping the regression failures under control?
>> The deluge of regression failures is a direct consequence of last minute
>> merges during (extended) feature freeze. We did well to contain this.
>> Great stuff!
>> If we want to avoid this we should not accept (large) feature merges
>> just before feature freeze.
> Hmm... I am not sure, most of the fixes in the last week I saw were bugs
> in tests or .rc files. The failures in afr and ec were problems that
> existed even in 3.6. They are showing up more now probably because 3.7
> is a bit more parallel.
> 
> Pranith
>>
>>> Here are some of the things that I can think of:
>>> 0) Maintainers should also maintain tests that are in their component.
>> It is not possible for me as glusterd co-maintainer to 'maintain'
>> tests that are added
>> under tests/bugs/glusterd. Most of them don't test core glusterd
>> functionality.
>> They are almost always tied to a particular feature whose
>> implementation had bugs
>> in its glusterd code. I would expect the test authors (esp. the more
>> recent ones) to chip in.
>> Thoughts/Suggestions?
> How about moving these tests to the respective component and not
> accepting tests in other components to be under tests/bugs/glusterd in
> future?
We should do that, we will migrate all such feature specific test cases
to their respective components.

~Atin
> 
> Pranith
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-devel

-- 
~Atin


More information about the Gluster-devel mailing list