[Bugs] [Bug 1810042] Changes to gluster peer probe in nightly build breaks ansible:gluster_volume call

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1810042

Sachin Prabhu <sprabhu at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Comment #0 is|1                           |0
            private|                            |



--- Comment #1 from Sachin Prabhu <sprabhu at redhat.com> ---
The quick patch below confirmed the cause. I suspect that we may be better off
fixing ansible:gluster_volume

commit 9972018b1a77db3becddd99b2e872917566f3539 (HEAD -> probe_regression)
Author: Sachin Prabhu <sprabhu at redhat.com>
Date:   Wed Mar 4 11:37:42 2020 +0000

    Fix regression in gluster probe

    Change-Id: Ibb8037b27b5cc246f2b4ac86a315e4a2a7c92e46

diff --git a/cli/src/cli-rpc-ops.c b/cli/src/cli-rpc-ops.c
index 0f57d94b5..3205f2895 100644
--- a/cli/src/cli-rpc-ops.c
+++ b/cli/src/cli-rpc-ops.c
@@ -158,9 +158,9 @@ gf_cli_probe_cbk(struct rpc_req *req, struct iovec *iov,
int count,

     gf_log("cli", GF_LOG_INFO, "Received resp to probe");

-    if (rsp.op_ret) {
-        if (rsp.op_errstr && rsp.op_errstr[0] != '\0') {
-            snprintf(msg, sizeof(msg), "%s", rsp.op_errstr);
+    if (rsp.op_errstr && rsp.op_errstr[0] != '\0') {
+        snprintf(msg, sizeof(msg), "%s", rsp.op_errstr);
+        if (rsp.op_ret) {
             gf_log("cli", GF_LOG_ERROR, "%s", msg);
         }
     }

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.