[Bugs] [Bug 1805055] New: Open fd heal should filter O_APPEND/O_EXCL

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1805055

            Bug ID: 1805055
           Summary: Open fd heal should filter O_APPEND/O_EXCL
           Product: GlusterFS
           Version: 5
            Status: NEW
         Component: disperse
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: pkarampu at redhat.com
                CC: atumball at redhat.com, bugs at gluster.org
        Depends On: 1733935
            Blocks: 1734303, 1735514, 1739426, 1739450
  Target Milestone: ---
    Classification: Community



+++ This bug was initially created as a clone of Bug #1733935 +++

Description of problem:
    Problem:
    when a file needs to be re-opened O_APPEND and O_EXCL
    flags are not filtered in EC.

    - O_APPEND should be filtered because EC doesn't send O_APPEND below EC for
    open to make sure writes happen on the individual fragments instead of at
the
    end of the file.

    - O_EXCL should be filtered because shd could have created the file so even
    without O_EXCL open should succeed.

    Fix:
    Filter out these two flags in reopen.


Version-Release number of selected component (if applicable):


How reproducible:
Found while reading code.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Amar Tumballi on 2019-07-30 05:25:19 UTC ---

https://review.gluster.org/#/c/glusterfs/+/23121/ posted.

--- Additional comment from Worker Ant on 2019-07-30 05:39:45 UTC ---

REVIEW: https://review.gluster.org/23121 (cluster/ec: Fix reopen flags to avoid
misbehavior) merged (#4) on master by Pranith Kumar Karampuri


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1733935
[Bug 1733935] Open fd heal should filter O_APPEND/O_EXCL
https://bugzilla.redhat.com/show_bug.cgi?id=1734303
[Bug 1734303] Open fd heal should filter O_APPEND/O_EXCL
https://bugzilla.redhat.com/show_bug.cgi?id=1735514
[Bug 1735514] Open fd heal should filter O_APPEND/O_EXCL
https://bugzilla.redhat.com/show_bug.cgi?id=1739426
[Bug 1739426] Open fd heal should filter O_APPEND/O_EXCL
https://bugzilla.redhat.com/show_bug.cgi?id=1739450
[Bug 1739450] Open fd heal should filter O_APPEND/O_EXCL
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.