[Bugs] [Bug 1719290] New: Glusterfs mount helper script not working with IPv6 because of regular expression or man is wrong

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1719290

            Bug ID: 1719290
           Summary: Glusterfs mount helper script not working with IPv6
                    because of regular expression or man is wrong
           Product: GlusterFS
           Version: 5
          Hardware: All
                OS: Linux
            Status: NEW
         Component: glusterd
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: aga_1990 at hotmail.com
                CC: bugs at gluster.org
  Target Milestone: ---
    Classification: Community



Version-Release number of selected component (if applicable): 5.6

Description of problem:
Based on man glusterfs I think this format should work: 

...
mount -t glusterfs [-o <options>] <server1>,<server2>,
              <server3>,..<serverN>:/<volname>[/<subdir>] <mount_point>
...

So list the servers and use , as the separator but as I see this doesn't work
well unfortunatelly with IPv6 addresses.

Command to try:
mount -t glusterfs fd00:16::106,fd00:16::107:/oam /mnt/test1/

In the log I see next: 
[2019-06-11 12:25:16.453643] I [MSGID: 100030] [glusterfsd.c:2725:main]
0-/usr/sbin/glusterfs: Started running /usr/sbin/glusterfs version 5.6 (args:
/usr/sbin/glusterfs --process-name fuse --volfile-server=fd00:16:
--volfile-id=oam /mnt/test1)

So the ipv6 address is wrong. 

Possible solution: 

In this file: /usr/sbin/mount.glusterfs the following line is wrong (nearby
line 720):
server_ip=$(echo "$volfile_loc" | sed -n 's/\([a-zA-Z0-9:%.\-]*\):.*/\1/p');
you should use this: 
server_ip=$(echo "$volfile_loc" | sed -n 's/\([a-zA-Z0-9:%,.\-]*\):.*/\1/p');
Because of the , is missing from the regex after %

After I applied this patch relevant lines from log:
[2019-06-11 12:33:40.345671] I [MSGID: 100030] [glusterfsd.c:2725:main]
0-/usr/sbin/glusterfs: Started running /usr/sbin/glusterfs version 5.6 (args:
/usr/sbin/glusterfs --process-name fuse --volfile-server=fd00:16::106
--volfile-server=fd00:16::107 --volfile-id=/oam /mnt/test1)

The IP looks like more better and the mount point is ok.


How reproducible:
Mount command provided above

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.