[Bugs] [Bug 1743988] Setting cluster.heal-timeout requires volume restart

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1743988



--- Comment #4 from Ravishankar N <ravishankar at redhat.com> ---
(In reply to Glen K from comment #3)
> 
> I would expect that the configuration would certainly take effect after a
> restart of the self-heal daemon.

In step-4 and 16, I assume you toggled `cluster.self-heal-daemon` off and on
respectively. This actually does not kill the shd process per se and just
disables/enables the heal crawls. In 6.5, a volume start force does restart shd
so changing the order of the tests should do the trick, i.e.

13. Set `cluster.heal-timeout` to `60`.
14. Force start the volume.
15. Verify that "split-brain" appears in the output of `gluster volume heal
<volume> info` command.


> Yes, launching heal manually causes the heal to happen right away, but the
> purpose of the test is to verify the heal happens automatically. From a user
> perspective, the current behaviour of the heal-timeout setting appears to be
> at odds with the "configuration changes take effect without restart"
> feature; I think it is reasonable to request that changing the heal-timeout
> setting results in the thread sleeps being reset to the new setting.

Fair enough, I'll attempt a fix on master, let us see how the review goes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.