[Bugs] [Bug 1694562] New: gfapi: do not block epoll thread for upcall notifications

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 1 05:59:32 UTC 2019


https://bugzilla.redhat.com/show_bug.cgi?id=1694562

            Bug ID: 1694562
           Summary: gfapi: do not block epoll thread for upcall
                    notifications
           Product: GlusterFS
           Version: 5
          Hardware: All
                OS: All
            Status: NEW
         Component: libgfapi
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: skoduri at redhat.com
        QA Contact: bugs at gluster.org
                CC: bugs at gluster.org, pasik at iki.fi
        Depends On: 1693575
            Blocks: 1694561
  Target Milestone: ---
    Classification: Community



+++ This bug was initially created as a clone of Bug #1693575 +++

Description of problem:

With https://review.gluster.org/#/c/glusterfs/+/21783/, we have made changes to
offload processing upcall notifications to synctask so as not to block epoll
threads. However seems like the purpose wasnt fully resolved. 

In "glfs_cbk_upcall_data" -> "synctask_new1" after creating synctask if there
is no callback defined, the thread waits on synctask_join till the syncfn is
finished. So that way even with those changes, epoll threads are blocked till
the upcalls are processed.

Hence the right fix now is to define a callback function for that synctask
"glfs_cbk_upcall_syncop" so as to unblock epoll/notify threads completely and
the upcall processing can happen in parallel by synctask threads.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Soumya Koduri on 2019-03-28 09:28:58 UTC ---

Users have complained about nfs-ganesha process getting stuck here -
https://github.com/nfs-ganesha/nfs-ganesha/issues/335

--- Additional comment from Worker Ant on 2019-03-28 09:34:11 UTC ---

REVIEW: https://review.gluster.org/22436 (gfapi: Unblock epoll thread for
upcall processing) posted (#1) for review on master by soumya k

--- Additional comment from Worker Ant on 2019-03-29 07:25:10 UTC ---

REVIEW: https://review.gluster.org/22436 (gfapi: Unblock epoll thread for
upcall processing) merged (#4) on master by Amar Tumballi


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1693575
[Bug 1693575] gfapi: do not block epoll thread for upcall notifications
https://bugzilla.redhat.com/show_bug.cgi?id=1694561
[Bug 1694561] gfapi: do not block epoll thread for upcall notifications
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list