[Bugs] [Bug 1640392] io-stats: garbage characters in the filenames generated

bugzilla at redhat.com bugzilla at redhat.com
Thu Oct 18 12:48:48 UTC 2018


Worker Ant <bugzilla-bot at gluster.org> changed:

           What    |Removed                     |Added
             Status|POST                        |MODIFIED

--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/21444 committed in release-5 by "Shyamsundar
Ranganathan" <srangana at redhat.com> with a commit message- debug/io-stats: io
stats filenames contain garbage

As dict_unserialize does not null terminate the value,
using snprintf adds garbage characters to the buffer
used to create the filename.
The code also used this->name in the filename which
will be the same for all bricks for a volume. The
files were thus overwritten if a node contained
multiple bricks for a volume. The code now uses
the conf->unique instead if available.

Change-Id: I2c72534b32634b87961d3b3f7d53c5f2ca2c068c
fixes: bz#1640392
Signed-off-by: N Balachandran <nbalacha at redhat.com>
(cherry picked from commit 219cd649fdbd7bfd6c2268a0a4f66bcc15918e31)

You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

More information about the Bugs mailing list