[Bugs] [Bug 1630804] libgfapi-python: test_listdir_with_stat and test_scandir failure on release 5 branch

bugzilla at redhat.com bugzilla at redhat.com
Wed Oct 17 03:48:09 UTC 2018


https://bugzilla.redhat.com/show_bug.cgi?id=1630804



--- Comment #24 from Prashanth Pai <ppai at redhat.com> ---
(In reply to Raghavendra G from comment #23)
> (In reply to Shyamsundar from comment #22)
> > > 
> > > > - inode NULL or not? Currently as the write has occured there would be an
> > > > inode linked and returning a NULL seems logically incorrect, iatt
> > > > invalidation seems to be the better option IMO
> > > > - Du?
> > > 
> > > This can be done. However, not sure about the scope of change as the present
> > > code implicitly assumes entry->inode being NULL as a proxy for stat not
> > > present.
> > 
> > I suggest iatt->ia_ctime being 0 as the trigger, which I understand is done
> > in other places.
> > 
> > If we agree to the above, changes would be in gfapi only, to resolve/stat
> > the inode again for iatt information.
> > 
> > Also, we need to conclude fast, just so we can release with the fix. Unless
> > there is disagreement that this is a blocker.
> 
> https://review.gluster.org/21396 already does that. But ppai reported its
> not fixing the issue. I would need help from gfapi maintainers to review the
> patch and take it to completion. Also, please feel free to modify the patch
> and merge.

It'll be good to add Shyam's C based reproducer as a test in the patch so that
edits/updates to the patch can surely tell if the fix works or not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.


More information about the Bugs mailing list