[Bugs] [Bug 1660701] Use adaptive mutex in rpcsvc_program_register to improve performance

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1660701

Raghavendra G <rgowdapp at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rgowdapp at redhat.com



--- Comment #4 from Raghavendra G <rgowdapp at redhat.com> ---
(In reply to Yaniv Kaul from comment #2)
> Is there upstream developer documentation on when they should be used and
> how?

Currently I am not aware of one. Even with [1] there was marginal regression
due to [1]. Thinking it was due to the mutex controlling access to the request
queue, I thought of using spinlocks as I was expecting critical section to be
very small (just adding/removing an element to list). However, pthread
conditional variables couldn't be used with spinlocks and hence as a second
option we tried adaptive mutex. After running perf benchmarks (small file
workload [3]) indeed showed adaptive mutex was helpful.

I referred to [4], which led to [5]

[1] https://review.gluster.org/r/I578c3fc67713f4234bd3abbec5d3fbba19059ea5
[2] https://review.gluster.org/17105
[3] https://github.com/distributed-system-analysis/smallfile
[4]
https://stackoverflow.com/questions/19863734/what-is-pthread-mutex-adaptive-np
[5] http://lkml.iu.edu/hypermail/linux/kernel/0103.1/0030.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.