[Bugs] [Bug 1193929] GlusterFS can be improved

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 31 06:17:54 UTC 2018


https://bugzilla.redhat.com/show_bug.cgi?id=1193929



--- Comment #314 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/20928 committed in master by "Amar Tumballi"
<amarts at redhat.com> with a commit message- NFS server (mount3.c, nfs-inodes.c):
strncpy()->sprintf(), reduce strlen()'s

xlators/nfs/server/src/mount3.c
xlators/nfs/server/src/nfs-inodes.c

strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.

Instead, use snprintf().

Compile-tested only!

Change-Id: Ibe74ccdb67434e9a10fc1f21c0b4cd5e4b8cb589
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list