[Bugs] [Bug 1193929] GlusterFS can be improved

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 24 16:28:09 UTC 2018


https://bugzilla.redhat.com/show_bug.cgi?id=1193929



--- Comment #278 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/20920 committed in master by "Amar Tumballi"
<amarts at redhat.com> with a commit message-
{mount-common|fusermount|mount_darwin|umountd}.c: strncpy()->sprintf(), reduce
strlen()'s

strncpy may not be very efficient for short strings copied into
a large buffer: If the length of src is less than n,
strncpy() writes additional null bytes to dest to ensure
that a total of n bytes are written.

Instead, use snprintf().

Also:
- save the result of strlen() and re-use it when possible.
- move from strlen to SLEN (sizeof() ) for const strings.

Compile-tested only!

Change-Id: I369209b36d8356c3fe00d32f8bf56e74cf9963db
updates: bz#1193929
Signed-off-by: Yaniv Kaul <ykaul at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list