[Bugs] [Bug 1614799] Geo-rep: Few workers fails to start with out any failure

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 13 03:52:34 UTC 2018


Worker Ant <bugzilla-bot at gluster.org> changed:

           What    |Removed                     |Added
             Status|POST                        |MODIFIED

--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/20704 committed in master by "Amar Tumballi"
<amarts at redhat.com> with a commit message- geo-rep: Fix deadlock during worker

Monitor process spawns monitor threads (one per brick).
Each monitor thread, forks worker and agent processes.
Each monitor thread, while intializing, updates the
monitor status file. It is synchronized using flock.
The race is that, some thread can fork worker while
other thread opened the status file resulting in
holding the reference of fd in worker process.

flock gets unlocked either by specifically unlocking it
or by closing all duplicate fds referring to the file.
The code was relying on fd close, hence a reference
in worker/agent process by fork could cause the deadlock.

1. flock is unlocked specifically.
2. Also made sure to update status file in approriate places so that
the reference is not leaked to worker/agent process.

With this fix, both the deadlock and possible fd
leaks is solved.

fixes: bz#1614799
Change-Id: I0d1ce93072dab07d0dbcc7e779287368cd9f093d
Signed-off-by: Kotresh HR <khiremat at redhat.com>

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CpG8tQz8vq&a=cc_unsubscribe

More information about the Bugs mailing list