[Bugs] [Bug 1615037] New: Multiplex tests use a cleanup pattern that results in empty tarballs on failure

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1615037

            Bug ID: 1615037
           Summary: Multiplex tests use a cleanup pattern that results in
                    empty tarballs on failure
           Product: GlusterFS
           Version: mainline
         Component: tests
          Keywords: Triaged
          Assignee: srangana at redhat.com
          Reporter: srangana at redhat.com
                CC: bugs at gluster.org



$SUMMARY is because the test is calling cleanup twice in its exit bash traps.

- First, the test itself sets a trap to cleanup at
https://github.com/gluster/glusterfs/blob/master/tests/bugs/core/multiplex-limit-issue-151.t#L30

- There is an additional trap set to cleanup in include.rc,
https://github.com/gluster/glusterfs/blob/master/tests/include.rc#L719

The tar ball is generated in the cleanup routine, and also ensures that
on content in the tar balls is between 2 invocations. Thus, calling
cleanup twice will result in an empty tarball.

This can be seen running the test locally as,
`./tests/bugs/distribute/bug-1042725.t`

There are a few things in that test we need clarified,
1. why trap this:
https://github.com/gluster/glusterfs/blob/master/tests/bugs/core/multiplex-limit-issue-151.t#L29
2. Why trap cleanup, rather than invoke it at the end of the test as is
normal

This pattern is repeated across the following tests:
tests/basic/mpx-compat.t
tests/basic/multiplex.t
tests/bugs/core/multiplex-limit-issue-151.t
tests/bugs/glusterd/brick-mux-validation.t

Fix is to revert this pattern to the normal cleanup at the end and remove the
traps set by these test cases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pBbHfszNMN&a=cc_unsubscribe