[Bugs] [Bug 1611115] New: avoid possible glusterd crash in glusterd_verify_slave

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1611115

            Bug ID: 1611115
           Summary: avoid possible glusterd crash in glusterd_verify_slave
           Product: GlusterFS
           Version: 4.1
         Component: geo-replication
          Assignee: bugs at gluster.org
          Reporter: khiremat at redhat.com
                CC: bugs at gluster.org, sunkumar at redhat.com
        Depends On: 1602121



+++ This bug was initially created as a clone of Bug #1602121 +++

Description of problem:
In 'glusterd_verify_slave' while  tokenizing error message we call 'strtok_r'
and store return value in 'tmp' which can be NULL. We are passing this 'tmp' as
1st argument to 'strcmp' which will lead to segmentation fault.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2018-07-17 16:37:16 EDT ---

REVIEW: https://review.gluster.org/20526 (geo-rep : fix possible crash) posted
(#1) for review on master by Sunny Kumar

--- Additional comment from Worker Ant on 2018-07-22 23:57:29 EDT ---

COMMIT: https://review.gluster.org/20526 committed in master by "Amar Tumballi"
<amarts at redhat.com> with a commit message- geo-rep : fix possible crash

Problem : In 'glusterd_verify_slave' while tokenizing error message
          we call 'strtok_r' and store return value in 'tmp' which
          can be NULL. We are passing this 'tmp' as 1st argument to
          'strcmp' which will lead to segmentation fault.
Solution : before calling 'strcmp' we should NULL check 'tmp'.

Change-Id: Ifd3864b904afe6cd09d9e5a4b55c6d0578e22b9d
fixes: bz#1602121
Signed-off-by: Sunny Kumar <sunkumar at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1602121
[Bug 1602121] avoid possible glusterd crash in glusterd_verify_slave
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.