[Bugs] [Bug 1440810] Update rfc.sh to check Change-Id consistency for backports

bugzilla at redhat.com bugzilla at redhat.com
Sat Apr 29 11:25:27 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1440810



--- Comment #2 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17031 committed in release-3.8 by Niels de
Vos (ndevos at redhat.com) 
------
commit ddf3d4d3785bbd4f964e54ebc72fd445662f21a5
Author: Shyam <srangana at redhat.com>
Date:   Wed Apr 5 14:22:57 2017 -0400

    scripts: Update rfc.sh to check existance of Change-Id in backports

    Addition to this script is a no-op on master.

    This would need to be backported to active release branches to be
    effective.

    This check is not smart proof, in that someone could proceed knowing
    that the Change-Id differs from master, but this is not expected to
    catch that, instead it is to serve more as a reminder that we need
    the same Change-Id across branches.

    Contributors not using rfc.sh would not see this, but they are few
    and possibly far in between. Also contributors using gerrit to
    cherry-pick changes will not see this. For both cases a server side
    solution to catch any changes are needed.

    There is a possiblilty that we will follow this up with a check
    on the gerrit end and add a comment to the reviews, to aid reviewers
    to quickly check the sanity of the Change-Id when it differs.

    > BUG: 1428047
    > Signed-off-by: Shyam <srangana at redhat.com>
    > Reviewed-on: https://review.gluster.org/17004
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Niels de Vos <ndevos at redhat.com>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    > Reviewed-by: Amar Tumballi <amarts at redhat.com>

    Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b
    BUG: 1440810
    Signed-off-by: Shyam <srangana at redhat.com>
    Reviewed-on: https://review.gluster.org/17031
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list