[Bugs] [Bug 1445213] Unable to take snapshot on a geo-replicated volume, even after stopping the session

bugzilla at redhat.com bugzilla at redhat.com
Fri Apr 28 09:39:23 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1445213



--- Comment #3 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17109 committed in release-3.8 by Aravinda
VK (avishwan at redhat.com) 
------
commit 57b481a071c13078c603cf2d96f9a04b9ebc39b4
Author: Kotresh HR <khiremat at redhat.com>
Date:   Thu Apr 20 07:18:52 2017 -0400

    glusterd/geo-rep: Fix snapshot create in geo-rep setup

    glusterd persists geo-rep sessions in glusterd
    info file which is represented by dictionary
    'volinfo->gsync_slaves' in memory. Glusterd also
    maintains in memory active geo-rep sessions in
    dictionary 'volinfo->gsync_active_slaves' whose key
    is "<slave_url>::<slavhost>".

    When glusterd is restarted while the geo-rep sessions
    are active, it builds the 'volinfo->gsync_active_slaves'
    from persisted glusterd info file. Since slave volume
    uuid is added to "voinfo->gsync_slaves" with the commit
    "http://review.gluster.org/13111", it builds it with key
    "<slave_url>::<slavehost>:<slavevol_uuid>" which is
    wrong. So during snapshot pre-validation which checks
    whether geo-rep is active or not, it always says it is
    ACTIVE, as geo-rep stop would not deleted this key.
    Fixed the same in this patch.


    > BUG: 1443977
    > Signed-off-by: Kotresh HR <khiremat at redhat.com>
    > Reviewed-on: https://review.gluster.org/17093
    > Smoke: Gluster Build System <jenkins at build.gluster.org>
    > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    > Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    (cherry picked from commit f071d2a285ea4802fe8f328f9f275180983fbbba)

    Change-Id: I185178910b4b8a62e66aba406d88d12fabc5c122
    BUG: 1445213
    Signed-off-by: Kotresh HR <khiremat at redhat.com>
    Reviewed-on: https://review.gluster.org/17109
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Aravinda VK <avishwan at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EzNfeeZs7H&a=cc_unsubscribe


More information about the Bugs mailing list