[Bugs] [Bug 1444773] New: explicitly specify executor to be bash for tests

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1444773

            Bug ID: 1444773
           Summary: explicitly specify executor to be bash for tests
           Product: GlusterFS
           Version: 3.10
         Component: tests
          Assignee: bugs at gluster.org
          Reporter: nbalacha at redhat.com
                CC: bugs at gluster.org, rtalur at redhat.com
        Depends On: 1438858



+++ This bug was initially created as a clone of Bug #1438858 +++

Description of problem:
We use prove command to run tests. Sometimes tests fail rather strangely with
error as shown below:



Not a perl script at ./tests/bugs/core/bug-1111557.t line 1.
./tests/bugs/core/bug-1111557.t .. 
Dubious, test returned 25 (wstat 6400, 0x1900)
No subtests run

https://build.gluster.org/job/centos6-regression/3818/consoleFull
https://build.gluster.org/job/centos6-regression/3819/consoleFull
https://build.gluster.org/job/centos6-regression/3801/consoleFull



Quote from man page

```
 "--exec"
       Normally you can just pass a list of Perl tests and the harness will
know how to execute them.  However, if your tests are
       not written in Perl or if you want all tests invoked exactly the same
way, use the "-e", or "--exec" switch:

        prove --exec '/usr/bin/ruby -w' t/
```

Hence, better to comply with recommended practice although it might not be the
reason for this failure.

--- Additional comment from Worker Ant on 2017-04-04 10:59:33 EDT ---

REVIEW: https://review.gluster.org/16996 (explicitly specify executor to be
bash for tests) posted (#1) for review on master by Raghavendra Talur
(rtalur at redhat.com)

--- Additional comment from Worker Ant on 2017-04-04 11:18:50 EDT ---

REVIEW: https://review.gluster.org/16996 (explicitly specify executor to be
bash for tests) posted (#2) for review on master by Raghavendra Talur
(rtalur at redhat.com)

--- Additional comment from Worker Ant on 2017-04-05 09:09:44 EDT ---

COMMIT: https://review.gluster.org/16996 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit d6b88e9b8b02813620c3c1a2ea49d58d29062b3e
Author: Raghavendra Talur <rtalur at redhat.com>
Date:   Tue Apr 4 20:28:07 2017 +0530

    explicitly specify executor to be bash for tests

    We use prove command to run tests. Sometimes tests fail rather strangely
    with error as shown below:

    Not a perl script at ./tests/bugs/core/bug-1111557.t line 1.
    ./tests/bugs/core/bug-1111557.t ..
    Dubious, test returned 25 (wstat 6400, 0x1900)
    No subtests run

    https://build.gluster.org/job/centos6-regression/3818/consoleFull
    https://build.gluster.org/job/centos6-regression/3819/consoleFull
    https://build.gluster.org/job/centos6-regression/3801/consoleFull

    Quote from man page

    ``
     "--exec"
           Normally you can just pass a list of Perl tests and the harness
    will know how to execute them.  However, if your tests are not written in
Perl
    or if you want all tests invoked exactly the same way, use the "-e",
    or "--exec" switch:

            prove --exec '/usr/bin/ruby -w' t/
    ```

    Hence, better to comply with recommended practice although it might not
    be the reason for this failure.

    Change-Id: If7a0baf20698f8497ef3e8fc422fa67063a4651f
    BUG: 1438858
    Signed-off-by: Raghavendra Talur <rtalur at redhat.com>
    Reviewed-on: https://review.gluster.org/16996
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Nigel Babu <nigelb at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jeff at pl.atyp.us>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1438858
[Bug 1438858] explicitly specify executor to be bash for tests
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.