[Bugs] [Bug 1425623] Free all xlator specific resources when xlator->fini() gets called

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1425623



--- Comment #16 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/16809 committed in master by Jeff Darcy
(jeff at pl.atyp.us) 
------
commit ef36ac0d1b72ab2c07ed6e0a3116b7265c3c0164
Author: Niels de Vos <ndevos at redhat.com>
Date:   Mon Feb 27 22:37:00 2017 -0800

    xlator: do not call dlclose() when debugging

    Valgrind can not show the symbols if a .so after calling dlclose(). The
    unhelpful ??? in the output gets resolved properly with this change:

      ==25170== 344 bytes in 1 blocks are definitely lost in loss record 233 of
324
      ==25170==    at 0x4C29975: calloc (vg_replace_malloc.c:711)
      ==25170==    by 0x52C7C0B: __gf_calloc (mem-pool.c:117)
      ==25170==    by 0x12B0638A: ???
      ==25170==    by 0x528FCE6: __xlator_init (xlator.c:472)
      ==25170==    by 0x528FE16: xlator_init (xlator.c:498)
      ==25170==    by 0x52DA8D6: glusterfs_graph_init (graph.c:321)
      ==25170==    by 0x52DB587: glusterfs_graph_activate (graph.c:695)
      ==25170==    by 0x5046407: glfs_process_volfp (glfs-mgmt.c:79)
      ==25170==    by 0x5043B9E: glfs_volumes_init (glfs.c:281)
      ==25170==    by 0x5044FEC: glfs_init_common (glfs.c:986)
      ==25170==    by 0x50451A7: glfs_init@@GFAPI_3.4.0 (glfs.c:1031)

    By not calling dlclose(), the dynamically loaded .so is still available
    upon program exit, and Valgrind is able to resolve the symbols. This
    will add an additional leak, so dlclose() is called for normal builds,
    but skipped when configuring with "./configure --enable-valgrind" or
    passing the "run-with-valgrind" xlator option.

    URL: http://valgrind.org/docs/manual/faq.html#faq.unhelpful
    Change-Id: I2044e21b1b8fcce32ad1a817fdd795218f967731
    BUG: 1425623
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: https://review.gluster.org/16809
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Samikshan Bairagya <samikshan at gmail.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7gcR9XAYVR&a=cc_unsubscribe