[Bugs] [Bug 1437330] Sharding: Fix a performance bug

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 4 08:54:27 UTC 2017


https://bugzilla.redhat.com/show_bug.cgi?id=1437330



--- Comment #3 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/16968 committed in release-3.8 by jiffin
tony Thottan (jthottan at redhat.com) 
------
commit 7920d7f3879ca5971d4e7ba569534934bfa676e8
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Tue Mar 28 19:26:41 2017 +0530

    features/shard: Pass the correct iatt for cache invalidation

            Backport of: https://review.gluster.org/16961

    This fixes a performance issue with shard which was causing
    the translator to trigger unusually high number of lookups
    for cache invalidation even when there was no modification to
    the file.

    In shard_common_stat_cbk(), it is local->prebuf that contains the
    aggregated size and block count as opposed to buf which only holds the
    attributes for the physical copy of base shard. Passing buf for
    inode_ctx invalidation would always set refresh to true since the file
    size in inode ctx contains the aggregated size and would never be same
    as @buf->ia_size. This was leading to every write/read being preceded
    by a lookup on the base shard even when the file underwent no
    modification.

    Change-Id: I85940b4b33e77b98e97e277d880ab35b1496c89a
    BUG: 1437330
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: https://review.gluster.org/16968
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.


More information about the Bugs mailing list