[Bugs] [Bug 1438340] New: glusterd is not validating for allowed values while setting " cluster.brick-multiplex" property

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1438340

            Bug ID: 1438340
           Summary: glusterd is not validating for allowed values while
                    setting "cluster.brick-multiplex"  property
           Product: GlusterFS
           Version: 3.10
         Component: glusterd
          Severity: low
          Assignee: bugs at gluster.org
          Reporter: gyadav at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org
        Depends On: 1425288



+++ This bug was initially created as a clone of Bug #1425288 +++

Description of problem:
glusterd is not validating for allowed values while setting
"cluster.brick-multiplex"  property.
When glusterd set cluster.brick-multiplex property allowed values are on/off,
but glusterd gives success message for all combination of string i.e 
gluster v set all cluster.brick-multiplex 12132131
gluster v set all cluster.brick-multiplex ababs

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a volume
2. gluster v set all cluster.brick-multiplex 12132131

Actual results:
glusterd gives success message for all the values

Expected results:
glusterd should error while setting unknown values.

Additional info:

--- Additional comment from Atin Mukherjee on 2017-02-21 06:40:09 EST ---

I don't see any patch posted against this bug, the status should be either in
NEW or ASSIGNED.

--- Additional comment from Worker Ant on 2017-02-21 12:53:04 EST ---

REVIEW: https://review.gluster.org/16704 (glusterd : cluster.brick-multiplex
validation is missing while setting it) posted (#1) for review on master by
Gaurav Yadav (gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-22 00:28:14 EST ---

REVIEW: https://review.gluster.org/16704 (glusterd : cluster.brick-multiplex
validation is missing while setting it) posted (#2) for review on master by
Gaurav Yadav (gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-22 00:31:18 EST ---

REVIEW: https://review.gluster.org/16704 (glusterd : cluster.brick-multiplex
validation is missing while setting it) posted (#3) for review on master by
Gaurav Yadav (gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-22 00:42:39 EST ---

REVIEW: https://review.gluster.org/16704 (glusterd : cluster.brick-multiplex
validation is missing while setting it) posted (#4) for review on master by
Gaurav Yadav (gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-22 06:05:59 EST ---

COMMIT: https://review.gluster.org/16704 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 60347526d9611035da0e56d55d4814f51cda9367
Author: Gaurav Yadav <gyadav at redhat.com>
Date:   Tue Feb 21 22:35:47 2017 +0530

    glusterd : cluster.brick-multiplex validation is missing while setting it

    Currently glusterd allow setting all values  while setting
cluster.brick-multiplex
    option. Validation of allowed options is missing.

    With this patch glusterd will validate the values given while setting
    cluster.brick-multiplex.

    Change-Id: I938fb16b8f5faa9d31326373cd18632b8aa7ebab
    BUG: 1425288
    Signed-off-by: Gaurav Yadav <gyadav at redhat.com>
    Reviewed-on: https://review.gluster.org/16704
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1425288
[Bug 1425288] glusterd is not validating for allowed values while setting
"cluster.brick-multiplex"  property
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.