[Bugs] [Bug 1438338] New: glusterd is setting replicate volume property over disperse volume or vice versa

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1438338

            Bug ID: 1438338
           Summary: glusterd is setting replicate volume property over
                    disperse volume or vice versa
           Product: GlusterFS
           Version: 3.10
         Component: glusterd
          Assignee: bugs at gluster.org
          Reporter: gyadav at redhat.com
                CC: bugs at gluster.org
        Depends On: 1417588



+++ This bug was initially created as a clone of Bug #1417588 +++

Description of problem:glusterd is setting replicate volume property over
disperse volume and viceversa lusterd is setting disperse volume property over
replicate volume 



Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
Case 1:
1.Create disperse volume
  gluster v create test-vol2 disperse 3 192.168.122.109:/d/backends/b{4,5,6}
force

2. Try to set 
gluster volume set test-vol2 cluster.shd-max-threads 1222

3.
Check for output of above commands

Case 2:
1.Create replicate volume
  gluster v create test-vol replicate 3 192.168.122.109:/d/backends/b{4,5,6}
force

2. Try to set 
gluster volume set test-vol2 disperse.shd-max-threads 1222

3.
Check for output of above command

Actual results:
For both the case glusterd is allowing client to set all values.(int, string)

Expected results:
For both the case glusterd should give error.



Additional info:

--- Additional comment from Worker Ant on 2017-01-31 05:46:21 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#1) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-02 04:41:22 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#2) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-13 05:19:13 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#3) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-13 12:59:32 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#4) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-22 05:19:41 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#5) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-03-06 02:21:55 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#6) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-03-06 05:22:52 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#7) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-03-06 07:45:27 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#8) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-03-06 08:04:21 EST ---

REVIEW: https://review.gluster.org/16489 (glusterd : Fix for replicate and
disperse volume option) posted (#9) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-03-06 11:51:58 EST ---

COMMIT: https://review.gluster.org/16489 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit c618de80696c4572fad9e28f0454e63ebb2ff4ed
Author: Gaurav Yadav <gyadav at redhat.com>
Date:   Tue Jan 31 16:14:46 2017 +0530

    glusterd : Fix for replicate and disperse volume option

    While setting volume option(disperse-shd-max-threads) for
    replicate volume and volume option(cluster-shd-max-threads)
    for disperse volume, glusterd is not validating volume options
    and setting all the values irrespective of proper validation
    for disperse-shd-max-threads and cluster-shd-max-threads

    Change-Id: Ic88815ad49e901e74ffc042170f5caabf7c17a89
    BUG: 1417588
    Signed-off-by: Gaurav Yadav <gyadav at redhat.com>
    Reviewed-on: https://review.gluster.org/16489
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1417588
[Bug 1417588] glusterd is setting replicate volume property over disperse
volume or vice versa
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.