[Bugs] [Bug 1438325] New: Need to improve remove-brick failure message when the brick process is down.

Mon Apr 3 05:14:52 UTC 2017

https://bugzilla.redhat.com/show_bug.cgi?id=1438325

            Bug ID: 1438325
           Summary: Need to improve remove-brick failure message when the
                    brick process is down.
           Product: GlusterFS
           Version: 3.10
         Component: glusterd
          Keywords: ZStream
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: gyadav at redhat.com
                CC: amukherj at redhat.com, bsrirama at redhat.com,
                    bugs at gluster.org, rhs-bugs at redhat.com,
                    storage-qa-internal at redhat.com, vbellur at redhat.com
        Depends On: 1339054, 1422624
            Blocks: 1423406

+++ This bug was initially created as a clone of Bug #1422624 +++

+++ This bug was initially created as a clone of Bug #1339054 +++

Description of problem:
======================
If we try to remove offline brick, the operation is failing with error message
"volume remove-brick start: failed: Found stopped brick
<hostname>:/bricks/brick1/a1" and this condition is added newly in 3.7.9-6
build.

Currently we have use force option to remove the offline brick and same thing
is expected in the failure message to use force option to remove the offline
brick to guide the user.

With this users will know the how to remove the offline brick.

Version-Release number of selected component (if applicable):
=============================================================
glusterfs-3.7.9-6

How reproducible:
=================
Always

Steps to Reproduce:
===================
1. Create a simple volume of any type and start it
2. Kill one of the volume brick
3. Try to remove the killed brick (offline brick) 
4. Check the brick failure error message //message won't convey how to remove
the brick.

Failure message getting:
=======================
]# gluster volume remove-brick Dis <hostname>:/bricks/brick1/a1 start
volume remove-brick start: failed: Found stopped brick
<hostname>:/bricks/brick1/a1

Actual results:
================
Failure is not saying how to remove the offline brick.

Expected results:
=================
Failure message need to have force option help message to remove the offline
brick.

Additional info:

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-05-24
00:35:31 EDT ---

This bug is automatically being proposed for the current z-stream release of
Red Hat Gluster Storage 3 by setting the release flag 'rhgs‑3.1.z' to '?'. 

If this bug should be proposed for a different release, please manually change
the proposed release flag.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-07-04
04:53:19 EDT ---

This bug is automatically being proposed for the current z-stream release of
Red Hat Gluster Storage 3 by setting the release flag 'rhgs‑3.1.z' to '?'. 

If this bug should be proposed for a different release, please manually change
the proposed release flag.

--- Additional comment from Rejy M Cyriac on 2016-09-17 12:33:32 EDT ---

Moving BZ to a transitional component in preparation for removing the
'glusterd' sub-component at the 'glusterd' component

--- Additional comment from Rejy M Cyriac on 2016-09-17 12:46:25 EDT ---

Moving BZ back to the 'glusterd' component after removal of the 'glusterd'
sub-component

--- Additional comment from Worker Ant on 2017-02-16 02:47:07 EST ---

REVIEW: https://review.gluster.org/16630 (glusterd : Fix for error message
while removing brick) posted (#1) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-16 03:49:53 EST ---

REVIEW: https://review.gluster.org/16630 (glusterd : Fix for error message
while removing brick) posted (#2) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-17 04:56:01 EST ---

REVIEW: https://review.gluster.org/16630 (glusterd : Fix for error message
while removing brick) posted (#3) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-17 04:58:55 EST ---

REVIEW: https://review.gluster.org/16630 (glusterd : Fix for error message
while removing brick) posted (#4) for review on master by Gaurav Yadav
(gyadav at redhat.com)

--- Additional comment from Worker Ant on 2017-02-17 09:47:37 EST ---

COMMIT: https://review.gluster.org/16630 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 64637d040d7f63ef6af6588ae17a557ad0229710
Author: Gaurav Yadav <gyadav at redhat.com>
Date:   Thu Feb 16 13:02:20 2017 +0530

    glusterd : Fix for error message while removing brick

    When remove-brick command is issued to a offline brick, glusterd
    error out the operation with message -: "volume remove-brick start:
    failed: Found stopped brick <hostname>:".

    With this fix while removing brick, error message is modified
    to "volume remove-brick start: failed: Found stopped brick
    <brick path>. Use force option to remove the brick"

    Change-Id: Id40a02fc38cdb526c4629de262967fe2383febe4
    BUG: 1422624
    Signed-off-by: Gaurav Yadav <gyadav at redhat.com>
    Reviewed-on: https://review.gluster.org/16630
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1339054
[Bug 1339054] Need to improve remove-brick failure message when the brick
process is down.
https://bugzilla.redhat.com/show_bug.cgi?id=1422624
[Bug 1422624] Need to improve remove-brick failure message when the brick
process is down.
https://bugzilla.redhat.com/show_bug.cgi?id=1423406
[Bug 1423406] Need to improve remove-brick failure message when the brick
process is down.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.