[Bugs] [Bug 1438255] New: Don' t wind post-op on a brick where the fop phase failed.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1438255

            Bug ID: 1438255
           Summary: Don't wind post-op on a brick where the fop phase
                    failed.
           Product: GlusterFS
           Version: mainline
         Component: replicate
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org



Problem:
    In afr-v2, self-blaming xattrs are not there by design. But if the FOP
    failed on a brick due to an error other than ENOTCONN (or even due to
    ENOTCONN, but we regained connection before postop was wound), we wind
    the post-op also on the failed brick, leading to setting self-blaming
    xattrs on that brick. This can lead to undesired results like healing of
    files in split-brain etc.

    Fix:
    If a fop failed on a brick on which pre-op was successful, do not
    perform post-op on it. This also produces the desired effect of not
    resetting the dirty xattr on the brick, which is how it should be
    because if the fop failed on a brick, there is no reason to clear the
    dirty bit which actually serves as an indication of the failure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.