[Bugs] [Bug 1339192] New: Missing autotools helper config.* files

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1339192

            Bug ID: 1339192
           Summary: Missing autotools helper config.* files
           Product: GlusterFS
           Version: 3.8.0
         Component: build
          Keywords: Triaged
          Severity: medium
          Assignee: ndevos at redhat.com
          Reporter: ndevos at redhat.com
                CC: bugs at gluster.org
        Depends On: 1223937



+++ This bug was initially created as a clone of Bug #1223937 +++

Hi,

your config.{guess,sub} files are from 2009-11-20 and outdated, which also
means that support for newer ports is missing.
I have attached more up to date versions.

--- Additional comment from Patrick Matthäi on 2015-05-21 20:26:56 CEST ---



--- Additional comment from Kaleb KEITHLEY on 2015-05-29 19:46:34 CEST ---

Our sources don't actually have config.guess and config.sub.

Our jenkins release task clones the source, runs ./autogen.sh (where
config.{guess,sub} come from) and ./configure, before running `make dist` to
product the release glusterfs-X.Y.Z.tar.gz.

The config.{guess,sub} in the tar file come from the archaic autoconf in CentOS
6.3, which is what the glusterfs jenkins is running on. We are working on
updating both jenkins and the platform it runs on.

Even so, we should not be shipping the (arbitrary, old) config.{guess,sub}
files from our jenkins machine.

--- Additional comment from Anand Avati on 2015-05-29 19:49:47 CEST ---

REVIEW: http://review.gluster.org/11009 (build: outdated autotools helper
config.* files in dist tarfile) posted (#1) for review on master by Kaleb
KEITHLEY (kkeithle at redhat.com)

--- Additional comment from Anand Avati on 2015-05-30 11:41:09 CEST ---

REVIEW: http://review.gluster.org/11009 (build: outdated autotools helper
config.* files in dist tarfile) posted (#2) for review on master by Kaleb
KEITHLEY (kkeithle at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-23 12:35:58 CEST ---

REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and
config.guess in releases) posted (#1) for review on master by Niels de Vos
(ndevos at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-23 13:47:33 CEST ---

REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and
config.guess in releases) posted (#2) for review on master by Niels de Vos
(ndevos at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-23 13:50:39 CEST ---

REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and
config.guess in releases) posted (#3) for review on master by Niels de Vos
(ndevos at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-23 17:12:57 CEST ---

REVIEW: http://review.gluster.org/14503 (build: include a dummy config.sub and
config.guess in releases) posted (#4) for review on master by Niels de Vos
(ndevos at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-24 12:54:41 CEST ---

COMMIT: http://review.gluster.org/14503 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit bfd43dc894fcf2cc64ec73e8ea0a779064c47dd4
Author: Niels de Vos <ndevos at redhat.com>
Date:   Mon May 23 11:06:38 2016 +0200

    build: include a dummy config.sub and config.guess in releases

    There is no hard requirement for a config.guess and config.sub script in
    the release tarball. By passing --build=... and --host=... to
    ./configure, the scripts are not executed.  When doing local builds, the
    ./autogen.sh script (by running automake) will place a config.guess and
    config.sub script in the root of the source tree. Upon creation of the
    release ('make dist') tarball, the scripts are replaced by dummy copies
    from the build-aux/ directory.

    The main advantage to not include these scripts in the repository, is
    that there is no need to track upstream updates for them either.

    Change-Id: I5e930988a9e849ec5d0c84d2e30e61f2a9685f45
    BUG: 1223937
    Reported-by: Emmanuel Dreyfus <manu at netbsd.org>
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/14503
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1223937
[Bug 1223937] Outdated autotools helper config.* files
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NOEC1Cz9wd&a=cc_unsubscribe