[Bugs] [Bug 1336268] features/index: clang compile warnings in index.c
bugzilla at redhat.com
bugzilla at redhat.com
Tue May 24 08:33:01 UTC 2016
https://bugzilla.redhat.com/show_bug.cgi?id=1336268
--- Comment #3 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14346 committed in release-3.8 by Niels de
Vos (ndevos at redhat.com)
------
commit b128a8983376c70b6f9f35ed60d54404da314624
Author: Ravishankar N <ravishankar at redhat.com>
Date: Fri May 13 12:41:39 2016 +0530
index: Fix compiler warning
Problem:
----------------------------
index.c:420:18: warning: comparison of unsigned enum expression < 0 is
always false [-Wtautological-compare]
if (type < 0 || type >= XATTROP_TYPE_END)
~~~~ ^ ~
1 warning generated.
----------------------------
Fix:
Add a -1 value in the enumeration and use that in if-statements.
Cherry picked from commit e221827c18ad4161a8e54ad67c9128ad234b8c03:
> BUG: 1335232
> Change-Id: I830a565b8d96d7b51ff775e94aa23dd567ffe0d9
> Signed-off-by: Niels de Vos <ndevos at redhat.com>
> Reviewed-on: http://review.gluster.org/14409
> Smoke: Gluster Build System <jenkins at build.gluster.com>
> Reviewed-by: Ravishankar N <ravishankar at redhat.com>
> CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
> NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
> Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
The backport prevens the need for commit 137bd83 to be backported.
Commit e221827 undoes the ugly type-casting.
Change-Id: I65911a05de5f8b5634f1e8cf359c38dad7d125aa
BUG: 1336268
Signed-off-by: Ravishankar N <ravishankar at redhat.com>
Signed-off-by: Niels de Vos <ndevow at redhat.com>
Reviewed-on: http://review.gluster.org/14346
Tested-by: Niels de Vos <ndevos at redhat.com>
Smoke: Gluster Build System <jenkins at build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VozREaYOxF&a=cc_unsubscribe
More information about the Bugs
mailing list