[Bugs] [Bug 1335531] Modified volume options are not syncing once glusterd comes up.

bugzilla at redhat.com bugzilla at redhat.com
Wed May 18 05:53:34 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1335531



--- Comment #7 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14306 committed in master by Kaushal M
(kaushal at redhat.com) 
------
commit 5a4f4a945661a8bb24735524e152ccd5b1ba571a
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Wed May 11 18:24:40 2016 +0530

    glusterd: copy real_path from older brickinfo during brick import

    In glusterd_import_new_brick () new_brickinfo->real_path will not be
populated
    for the first time and hence if the underlying file system is bad for the
same
    brick, import will fail resulting in inconsistent configuration data.

    Fix is to populate real_path from old brickinfo object.

    Also there were many cases where we were unnecessarily calling realpath()
and
    that may cause in failure. For eg - if a remove brick is executed with a
brick
    whoose underlying file system has crashed, remove-brick fails since
realpath()
    call fails. We'd need to call realpath() here as the value is of no
use.Hence
    passing construct_realpath as _gf_false in
glusterd_volume_brickinfo_get_by_brick ()
    is a must in such cases.

    Change-Id: I7ec93871dc9e616f5d565ad5e540b2f1cacaf9dc
    BUG: 1335531
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/14306
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaushal M <kaushal at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aZQiCSHk0e&a=cc_unsubscribe


More information about the Bugs mailing list