[Bugs] [Bug 1335652] Heal info shows split-brain for .shard directory though only one brick was down

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1335652



--- Comment #4 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14310 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 53d16409f933110da11338ef26d1fa7b2e921cec
Author: Anuradha Talur <atalur at redhat.com>
Date:   Fri May 13 15:34:06 2016 +0530

    cluster/afr : Do post-op in case of symmetric errors

    In afr_changelog_post_op_now(), if there was any error,
    meaning op_ret < 0, post-op was not being done even when
    the errors were symmetric and there were no "failed
    subvols".

    Fix:
    When the errors are symmetric, perform post-op.

    How was the bug found :
    In a 1 X 3 volume with shard and write behind on
    when writes were done into a file with one brick down,
    the trusted.afr.dirty xattr's value for .shard directory
    would keep increasing as post op was not done but pre-op was.
    This incorrectly showed .shard to be in split-brain.

    RCA:
    When WB is on, due to multiple writes being sent on
    offset lying in the same shard, chances are that
    same shard file will be created more than once
    with the second one failing with op_ret < 0
    and op_errno = EEXIST.

    As op_ret was negative, afr wouldn't do post-op,
    leading to no decrement of trusted.afr.dirty xattr.
    Thus showing .shard directory to be in split-brain.

    Change-Id: I711bdeaa1397244e6a7790e96f0c84501798fc59
    BUG: 1335652
    Signed-off-by: Anuradha Talur <atalur at redhat.com>
    Reviewed-on: http://review.gluster.org/14310
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Ravishankar N <ravishankar at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gv78KDmgAp&a=cc_unsubscribe