[Bugs] [Bug 1335282] New: Wrong constant used in length based comparison for XATTR_SECURITY_PREFIX

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1335282

            Bug ID: 1335282
           Summary: Wrong constant used in length based comparison for
                    XATTR_SECURITY_PREFIX
           Product: GlusterFS
           Version: 3.8.0
         Component: core
          Keywords: EasyFix, Triaged
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: pkarampu at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    ndevos at redhat.com, pkarampu at redhat.com,
                    pportant at redhat.com
        Depends On: 1331860



+++ This bug was initially created as a clone of Bug #1331860 +++

In libglusterfs/src/syscall.c, line 353, shouldn't XATTR_SECURITY_PREFIX_LEN be
used instead of XATTR_TRUSTED_PREFIX_LEN?

https://github.com/gluster/glusterfs/blob/30b66ef3750ece0fb56e673afaca7948d53511e1/libglusterfs/src/syscall.c#L353

--- Additional comment from Atin Mukherjee on 2016-04-30 02:51:45 EDT ---

This doesn't fall into glusterd. Changing the component to core.

--- Additional comment from Vijay Bellur on 2016-05-04 01:23:48 EDT ---

REVIEW: http://review.gluster.org/14194 (libglusterfs: Fix security prefix
comparison) posted (#1) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-05-04 07:28:32 EDT ---

COMMIT: http://review.gluster.org/14194 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 7d431c14bc458e9451e9c737f5879968a7b6a0b9
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Wed May 4 10:19:23 2016 +0530

    libglusterfs: Fix security prefix comparison

    BUG: 1331860
    Change-Id: If35012ee35104848d7d3b21900c7f533d0253cde
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/14194
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1331860
[Bug 1331860] Wrong constant used in length based comparison for
XATTR_SECURITY_PREFIX
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.