[Bugs] [Bug 1333237] New: DHT: Once remove brick start failed in between Remove brick commit should not be allowed

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1333237

            Bug ID: 1333237
           Summary: DHT: Once remove brick start failed in between Remove
                    brick commit should not be allowed
           Product: GlusterFS
           Version: 3.7.11
         Component: distribute
          Keywords: ZStream
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: sabansal at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    mselvaga at redhat.com, rmekala at redhat.com,
                    sabansal at redhat.com, sasundar at redhat.com,
                    spalai at redhat.com, storage-qa-internal at redhat.com
        Depends On: 1258875, 1278325
            Blocks: 1332370



+++ This bug was initially created as a clone of Bug #1278325 +++

+++ This bug was initially created as a clone of Bug #1258875 +++

Document URL: 
=============
DHT: Once remove brick start failed in between Remove brick commit should not
be allowed 

Steps:
========
1. Create a distributed volume with three bricks and mount it on client using
FUSE
2. From the mount point create lots of directories and one direcotry with 30k
files
3. Remove one of the brick form the volume and while re-blance is in progress
delete all directories and files from the mount point and due to this
remove-brick operation failed 
4.Though remove-brick operation failed remove-commint job is getting succeeded, 

Expected Result:
================
Remove-brick commit should be allowed only when the remove-brick operation job
is passed

--- Additional comment from Sakshi on 2016-01-08 04:18:00 EST ---

Patch posted at http://review.gluster.org/#/c/12513/

--- Additional comment from Vijay Bellur on 2016-02-04 03:59:26 EST ---

REVIEW: http://review.gluster.org/12513 (glusterd: remove-brick commit should
not be allowed when remove-brick start failed) posted (#2) for review on master
by Sakshi Bansal

--- Additional comment from Vijay Bellur on 2016-02-24 05:13:21 EST ---

REVIEW: http://review.gluster.org/12513 (glusterd: remove-brick commit should
not succeed when migration failed) posted (#3) for review on master by Sakshi
Bansal

--- Additional comment from Mike McCune on 2016-03-28 19:31:34 EDT ---

This bug was accidentally moved from POST to MODIFIED via an error in
automation, please see mmccune at redhat.com with any questions

--- Additional comment from Vijay Bellur on 2016-04-07 02:33:24 EDT ---

REVIEW: http://review.gluster.org/12513 (glusterd: remove-brick commit should
not succeed when migration failed) posted (#4) for review on master by Sakshi
Bansal

--- Additional comment from Vijay Bellur on 2016-05-02 23:53:22 EDT ---

COMMIT: http://review.gluster.org/12513 committed in master by Atin Mukherjee
(amukherj at redhat.com) 
------
commit 614a048c59d9b22e090acc0f1bdcb8c1be67f97a
Author: Sakshi Bansal <sabansal at redhat.com>
Date:   Thu Nov 5 15:09:31 2015 +0530

    glusterd: remove-brick commit should not succeed when migration failed

    While remove a brick if the data migration was not successful,
    remove-brick commit should not succeed as this can lead to
    data loss.

    Change-Id: I1eac0ef775cc6910ece0e46ebb04051444d54393
    BUG: 1278325
    Signed-off-by: Sakshi Bansal <sabansal at localhost.localdomain>
    Reviewed-on: http://review.gluster.org/12513
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Tested-by: Atin Mukherjee <amukherj at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1258875
[Bug 1258875] DHT: Once remove brick start failed in between Remove brick
commit should not be allowed
https://bugzilla.redhat.com/show_bug.cgi?id=1278325
[Bug 1278325] DHT: Once remove brick start failed in between Remove brick
commit should not be allowed
https://bugzilla.redhat.com/show_bug.cgi?id=1332370
[Bug 1332370] DHT: Once remove brick start failed in between Remove brick
commit should not be allowed
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.