[Bugs] [Bug 1332838] New: rpc: assign port only if it is unreserved

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1332838

            Bug ID: 1332838
           Summary: rpc: assign port only if it is unreserved
           Product: GlusterFS
           Version: 3.7.11
         Component: rpc
          Assignee: bugs at gluster.org
          Reporter: prasanna.kalever at redhat.com
                CC: bugs at gluster.org
        Depends On: 1323659



+++ This bug was initially created as a clone of Bug #1323659 +++

Description of problem:
basically we are assigning port first then checking if it is reserved

Version-Release number of selected component (if applicable):
mainline

Fix:
we get unreserved port first and then assign it

--- Additional comment from Vijay Bellur on 2016-04-04 07:25:04 EDT ---

REVIEW: http://review.gluster.org/13900 (rpc: assign port only if it is
unreserved) posted (#1) for review on master by Prasanna Kumar Kalever
(pkalever at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-04 07:34:02 EDT ---

REVIEW: http://review.gluster.org/13900 (rpc: assign port only if it is
unreserved) posted (#2) for review on master by Prasanna Kumar Kalever
(pkalever at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-06 13:08:50 EDT ---

COMMIT: http://review.gluster.org/13900 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 7370633b6404bbd3c8238b464bc413689dcccf93
Author: Prasanna Kumar Kalever <prasanna.kalever at redhat.com>
Date:   Mon Apr 4 16:15:18 2016 +0530

    rpc: assign port only if it is unreserved

    Current order:
        assign port;
        check for port;
        if reserved {
            port--;
            continue to i;
        }
        bind();

    basically, we are assigning port first then checking if it is reserved

    Fix:
        get unreserved port;
        assign port;
        bind();

    from now, we get unreserved port first and then assign it

    Change-Id: I004580c5215e7c9cae3594af6405b20fcd9fa4ad
    BUG: 1323659
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever at redhat.com>
    Reviewed-on: http://review.gluster.org/13900
    Tested-by: Prasanna Kumar Kalever <pkalever at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra Talur <rtalur at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1323659
[Bug 1323659] rpc: assign port only if it is unreserved
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.