[Bugs] [Bug 1332554] New: runner: extract and return actual exit status of child

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1332554

            Bug ID: 1332554
           Summary: runner: extract and return actual exit status of child
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: glusterfs
     Sub Component: core
          Assignee: rhs-bugs at redhat.com
          Reporter: prasanna.kalever at redhat.com
        QA Contact: annair at redhat.com
                CC: bugs at gluster.org
        Depends On: 1329129
            Blocks: 1331759



+++ This bug was initially created as a clone of Bug #1329129 +++

Description of problem:

In the current runner framework we always return the pid i.e ret value of the
waitpid, as said above it is not the exit value of the child process

Version-Release number of selected component (if applicable):
mainline

Actual results:
returning the ret value of waitpid()

Expected results:
extract the exit code and return the actual exit status of the child process

--- Additional comment from Vijay Bellur on 2016-04-21 07:44:46 EDT ---

REVIEW: http://review.gluster.org/14042 (runner: extract and return actual exit
status of child) posted (#1) for review on master by Prasanna Kumar Kalever
(pkalever at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-25 10:18:13 EDT ---

COMMIT: http://review.gluster.org/14042 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 19fd9a371fff4ece2c617f1e7194ffcee039f21e
Author: Prasanna Kumar Kalever <prasanna.kalever at redhat.com>
Date:   Thu Apr 21 14:38:16 2016 +0530

    runner: extract and return actual exit status of child

    Intro:
    pid_t waitpid(pid_t pid, int *status, int options);

    The waitpid() system call suspends execution of the calling process
    until a child specified by pid  argument has  changed  state.

    Here the ret (pid) value is not equal to the exit status of the child
process.
    Check manpages for more info on this.

    Problem:
    In the current runner framework we always return the pid i.e ret value
    of the waitpid, as said above it is not the exit value of the child process

    Solution:
    Extract the actual exit code/status in case if the child terminated
normally,
    that is, by calling exit(3) or _exit(2), or by returning from main()

    Change-Id: Iffae99a43e540af66917b3745f21ea3c2a5a3c2d
    BUG: 1329129
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever at redhat.com>
    Reviewed-on: http://review.gluster.org/14042
    Tested-by: Prasanna Kumar Kalever <pkalever at redhat.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1329129
[Bug 1329129] runner: extract and return actual exit status of child
https://bugzilla.redhat.com/show_bug.cgi?id=1331759
[Bug 1331759] runner: extract and return actual exit status of child
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qurHaqTkiZ&a=cc_unsubscribe