[Bugs] [Bug 1332404] New: the wrong variable was being checked for gf_strdup

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1332404

            Bug ID: 1332404
           Summary: the wrong variable was being checked for gf_strdup
           Product: GlusterFS
           Version: 3.7.11
         Component: rpc
          Keywords: EasyFix
          Severity: low
          Priority: low
          Assignee: bugs at gluster.org
          Reporter: anoopcs at redhat.com
                CC: anoopcs at redhat.com, bugs at gluster.org,
                    johnzzpcrystal at gmail.com
        Depends On: 1325683



+++ This bug was initially created as a clone of Bug #1325683 +++

in function  rpc_transport_inet_options_build :

host = gf_strdup ((char*)hostname);
if (!hostname) {
    ret = -1;
    goto out;
}

hostname should be host

--- Additional comment from Vijay Bellur on 2016-04-10 21:28:27 IST ---

REVIEW: http://review.gluster.org/13934 (rpc: check the right variable after
gf_strdup) posted (#1) for review on master by Zhou Zhengping
(johnzzpcrystal at gmail.com)

--- Additional comment from Vijay Bellur on 2016-04-11 20:26:07 IST ---

REVIEW: http://review.gluster.org/13934 (rpc: check the right variable after
gf_strdup) posted (#2) for review on master by Zhou Zhengping
(johnzzpcrystal at gmail.com)

--- Additional comment from Vijay Bellur on 2016-04-12 05:24:51 IST ---

REVIEW: http://review.gluster.org/13934 (rpc: check the right variable after
gf_strdup) posted (#3) for review on master by Zhou Zhengping
(johnzzpcrystal at gmail.com)

--- Additional comment from Vijay Bellur on 2016-04-14 18:21:54 IST ---

COMMIT: http://review.gluster.org/13934 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 1c9c776352c60deeda51be66fda6d44bf06d3796
Author: Zhou Zhengping <johnzzpcrystal at gmail.com>
Date:   Sun Apr 10 23:56:17 2016 +0800

    rpc: check the right variable after gf_strdup

    Change-Id: If4628bd37f2c85a070f6c3b3e0583d939100d7ec
    BUG: 1325683
    Signed-off-by: Zhou Zhengping <johnzzpcrystal at gmail.com>
    Reviewed-on: http://review.gluster.org/13934
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: Jeff Darcy <jdarcy at redhat.com>
    Reviewed-by: Anoop C S <anoopcs at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1325683
[Bug 1325683] the wrong variable was being checked for gf_strdup
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.