[Bugs] [Bug 1332387] New: Client log gets flooded by default with fop stats under DEBUG level

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1332387

            Bug ID: 1332387
           Summary: Client log gets flooded by default with fop stats
                    under DEBUG level
           Product: GlusterFS
           Version: 3.7.11
         Component: io-stats
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: anoopcs at redhat.com
                CC: asengupt at redhat.com, bugs at gluster.org,
                    jdarcy at redhat.com, ndevos at redhat.com, rwareing at fb.com,
                    srangana at redhat.com
        Depends On: 1320101



+++ This bug was initially created as a clone of Bug #1320101 +++

Description of problem:
By default raising the client log level to DEBUG will dump JSON fop statistics
every 5 seconds to client logs. It's annoying to see all those stats even if
someone is not interested. In addition to that it will eats up the disk space
very fast.

Version-Release number of selected component (if applicable):
master

How reproducible:
Always

Steps to Reproduce:
1. Create a simple 1-brick distribute volume.
2. Start the volume and do the following volume set operation
# gluster volume set <VOLNAME> diagnostics.client-log-level DEBUG
3. Check client logs.

Actual results:
Huge dump of json fop statistics are dumped very fast.

Expected results:
No fop statistics dump are seen in client logs.

Additional info:
Even though we do have a volume set option(diagnostics.stats-dump-interval) to
disable this dumping of fop stats to client logs, it is not taken into effect
unless a re-mount of the volume is done.

--- Additional comment from Vijay Bellur on 2016-03-22 15:59:16 IST ---

REVIEW: http://review.gluster.org/13808 (debug/io-stats: Disable fop stats dump
by default) posted (#1) for review on master by Anoop C S (anoopcs at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-24 20:35:24 IST ---

COMMIT: http://review.gluster.org/13808 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit 91004b046805243e730176a5354ce3092326dde4
Author: Anoop C S <anoopcs at redhat.com>
Date:   Tue Mar 22 15:51:37 2016 +0530

    debug/io-stats: Disable fop stats dump by default

    Even though someone is not interested in seeing the fops statistics in
    client logs under DEBUG level we forcefully dump the same. This is due
    to default dump-interval configured to as 5 seconds. Since can use
    diagnostics.stats-dump-interval volume set option to change the default
    dump-interval its better to disable this huge dumping by default.

    Change-Id: Id14a38bcd92e47d75003279567a0f80acac1d86e
    BUG: 1320101
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-on: http://review.gluster.org/13808
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

--- Additional comment from Mike McCune on 2016-03-29 03:53:05 IST ---

This bug was accidentally moved from POST to MODIFIED via an error in
automation, please see mmccune at redhat.com with any questions


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1320101
[Bug 1320101] Client log gets flooded by default with fop stats under DEBUG
level
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.