[Bugs] [Bug 1332372] New: Do not succeed mkdir without gfid-req

Tue May 3 05:50:00 UTC 2016

https://bugzilla.redhat.com/show_bug.cgi?id=1332372

            Bug ID: 1332372
           Summary: Do not succeed mkdir without gfid-req
           Product: GlusterFS
           Version: 3.7.11
         Component: posix
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: anoopcs at redhat.com
                CC: bugs at gluster.org, pkarampu at redhat.com
        Depends On: 1317361
            Blocks: 1321550

+++ This bug was initially created as a clone of Bug #1317361 +++

Description of problem:
    Do not allow directory creations without gfids as it is a pain
    to fix the gfids. After the directories are created, operations
    on them fail anyway. So it is better to fail mkdir.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

--- Additional comment from Vijay Bellur on 2016-03-14 11:46:36 IST ---

REVIEW: http://review.gluster.org/13690 (storage/posix: Fail mkdir without
gfid-req) posted (#1) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-14 12:48:26 IST ---

REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir
without gfid-req) posted (#2) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-15 11:33:09 IST ---

REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir
without gfid-req) posted (#3) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-16 11:59:39 IST ---

REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir
without gfid-req) posted (#4) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-16 13:09:29 IST ---

REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir
without gfid-req) posted (#5) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-16 19:06:09 IST ---

REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir
without gfid-req) posted (#6) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-03-18 17:30:11 IST ---

REVIEW: http://review.gluster.org/13776 (features/trash: wind mkdir with
special pid) posted (#1) for review on master by Anoop C S (anoopcs at redhat.com)

--- Additional comment from Mike McCune on 2016-03-29 03:53:05 IST ---

This bug was accidentally moved from POST to MODIFIED via an error in
automation, please see mmccune at redhat.com with any questions

--- Additional comment from Vijay Bellur on 2016-04-17 13:56:30 IST ---

REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir
without gfid-req) posted (#7) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-26 21:01:28 IST ---

REVIEW: http://review.gluster.org/13776 (features/trash: wind mkdir with
special pid) posted (#2) for review on master by Anoop C S (anoopcs at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-27 18:11:23 IST ---

REVIEW: http://review.gluster.org/13776 (features/trash: wind mkdir with
special pid) posted (#3) for review on master by Jeff Darcy (jdarcy at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-28 02:54:51 IST ---

COMMIT: http://review.gluster.org/13776 committed in master by Jeff Darcy
(jdarcy at redhat.com) 
------
commit b5cfe948cb3569f034da80ac97b5d2f028b3b0e5
Author: Anoop C S <anoopcs at redhat.com>
Date:   Fri Mar 18 10:32:09 2016 +0530

    features/trash: wind mkdir with special pid

    Recent changes done w.r.t handling of mkdir calls in posix translator
    resulted in crashing the brick process from trash translator. This was
    due to the changes made in posix translator to return EPERM for every
    mkdir calls without 'gfid-req' set in dictionary. In order to avoid
    gfid mismatches during directory creation from brick side trash
    translator does not set 'gfid-req'. This patch is to have an exemption
    for trash based on a special pid set for those mkdir calls originating
    from trash translator and to reset it in callback.

    This patch also includes a small optimization to the existing test case
    for trash feature.

    Change-Id: I59f084ac875e54342ecf2bffa6e43ebd84814153
    BUG: 1317361
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-on: http://review.gluster.org/13776
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Jeff Darcy <jdarcy at redhat.com>

--- Additional comment from Vijay Bellur on 2016-04-28 12:41:24 IST ---

REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir
without gfid-req) posted (#8) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-28 17:02:39 IST ---

REVIEW: http://review.gluster.org/13690 (dht/afr/client/posix: Fail mkdir
without gfid-req) posted (#9) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Vijay Bellur on 2016-04-29 19:27:43 IST ---

COMMIT: http://review.gluster.org/13690 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit b246b07896fefb261c9fb07f3f29f0d03b81b88d
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Mon Mar 14 10:59:38 2016 +0530

    dht/afr/client/posix: Fail mkdir without gfid-req

    Do not allow directory creations without gfids as
    after the directories are created, operations
    on them fail anyway. So it is better to fail mkdir.

    BUG: 1317361
    Change-Id: I8f8e3b38bbded1960b7215bac0432500f7e78038
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/13690
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1317361
[Bug 1317361] Do not succeed mkdir without gfid-req
https://bugzilla.redhat.com/show_bug.cgi?id=1321550
[Bug 1321550] Do not succeed mkdir without gfid-req
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.