[Bugs] [Bug 1329211] values for Number of Scrubbed files, Number of Unsigned files, Last completed scrub time and Duration of last scrub are shown as zeros in bit rot scrub status
bugzilla at redhat.com
bugzilla at redhat.com
Mon May 2 04:33:36 UTC 2016
https://bugzilla.redhat.com/show_bug.cgi?id=1329211
--- Comment #16 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/14044 committed in master by Venky Shankar
(vshankar at redhat.com)
------
commit db468e4361315a91aaeeaa14ff7e6b448e2c8599
Author: Kotresh HR <khiremat at redhat.com>
Date: Fri Apr 29 17:45:31 2016 +0530
features/bitrot: Introduce scrubber monitor thread
The patch does following changes.
1. Introduce scrubber monitor thread.
2. Move scrub status related APIs to separate file
and make part of libbitrot library.
Problem:
Earlier, each child of the scrubber was maintaining
the state machine and hence there was no way to track
the start and end time of scrubbing as each brick has
it's own start and end time. Also each brick was maintaining
it's own timer wheel instance. It was also not possible
to get scrubbed files count per session as we could not
get last child which finishes scrubbing to reset it to
zero.
Solution:
Introduce scrubber monitor thread. It does following.
1. Maintains the scrubber state machine. Earlier each
child had it's own state machine. Now, only monitor
maintains on behalf of all it's children.
2. Maintains the timer wheel instance. Earlier each
child had it's own timer wheel instance. Now, only
monitor maintains on behalf of all it's children.
As a result, we can track the scrub statistics easily
and correctly.
Change-Id: Ic6e34ffa57984bd7a5ee81f4e263342bc1d9b302
BUG: 1329211
Signed-off-by: Kotresh HR <khiremat at redhat.com>
Reviewed-on: http://review.gluster.org/14044
Smoke: Gluster Build System <jenkins at build.gluster.com>
NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: Venky Shankar <vshankar at redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the Docs Contact for the bug.
More information about the Bugs
mailing list