[Bugs] [Bug 1304963] [GlusterD]: After log rotate of cmd_history.log file, the next executed gluster commands are not present in the cmd_history.log file.
bugzilla at redhat.com
bugzilla at redhat.com
Thu Mar 31 07:53:49 UTC 2016
https://bugzilla.redhat.com/show_bug.cgi?id=1304963
--- Comment #6 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/13847 committed in release-3.7 by Kaushal M
(kaushal at redhat.com)
------
commit 2cd5b752c1123095acff5ce57649393ab1de7aaf
Author: Atin Mukherjee <amukherj at redhat.com>
Date: Mon Mar 28 10:49:43 2016 +0530
libglusterfs: open cmd_history log file with O_APPEND and O_WRONLY
Commit 8fdfa0c introduced a fix to ensure cmd_history file is log rotated
properly. However with this fix fdopen() is called with mode "a" on a fd
which
was not opened with O_WRONLY & O_APPEND resulting into a fdopen() failure.
Fix is to open cmd_history.log file with O_CREATE|O_WRONLY|O_APPEND mode
Backport of commit 207289621f6c5b75bdb80aa14ddaf72efd5eb9b1:
> Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
> BUG: 1286959
> Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
> Reviewed-on: http://review.gluster.org/13829
> Smoke: Gluster Build System <jenkins at build.gluster.com>
> Reviewed-by: Niels de Vos <ndevos at redhat.com>
> NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
> CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
Change-Id: I75ef350560aa6d5435c78c5fd83adfde1a73bfc3
BUG: 1304963
Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
Reviewed-on: http://review.gluster.org/13847
NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
Reviewed-by: Niels de Vos <ndevos at redhat.com>
Smoke: Gluster Build System <jenkins at build.gluster.com>
CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YxuYrWrY6N&a=cc_unsubscribe
More information about the Bugs
mailing list