[Bugs] [Bug 1321955] [GSS] Self-heal and manual heal not healing some file

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 31 04:23:26 UTC 2016


https://bugzilla.redhat.com/show_bug.cgi?id=1321955



--- Comment #6 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/13845 committed in master by Venky Shankar
(vshankar at redhat.com) 
------
commit 9746ee75865162af1827337f22a553ea0c3ba2ed
Author: Kotresh HR <khiremat at redhat.com>
Date:   Tue Mar 29 19:06:46 2016 +0530

    features/changelog: Don't modify 'pargfid' in 'resolve_pargfid_to_path'

    If 'changelog' is enabled and 'changelog.capture-del-path' option is on
    it calls 'resolve_pargfid_to_path' which modifies 'pargfid' sent by
    caller.  'changelog_unlink' calls this routine directly with
    'loc->pargfid' resulting it being modified and point to root instead of
    actual pargfid. This is a nasty bug and could cause the deletion of
    entry on root directory instead on actual parent when 'loc->path' is
    not present.  Hence this fix to make 'pargfid' a const pointer and
    'resolve_pargfid' to work on copy of pargfid.

    Glusterfind session creation enables these options by default to
    capture deleted entry path in changelog.

    Thanks Pranith for root causing this.

    Change-Id: I1d275a86f91c981b6889bedef93401c039d01d71
    BUG: 1321955
    Signed-off-by: Kotresh HR <khiremat at redhat.com>
    Reviewed-on: http://review.gluster.org/13845
    Smoke: Gluster Build System <jenkins at build.gluster.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Reviewed-by: Venky Shankar <vshankar at redhat.com>
    Reviewed-by: Ravishankar N <ravishankar at redhat.com>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the Bugs mailing list