[Bugs] [Bug 1319649] libglusterfs : glusterd was not restarting after setting key=value length beyond PATH_MAX (4096) character

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1319649



--- Comment #3 from Vijay Bellur <vbellur at redhat.com> ---
COMMIT: http://review.gluster.org/13795 committed in release-3.7 by Niels de
Vos (ndevos at redhat.com) 
------
commit 12861b75dcc2319067cabc903e688b4ceb4763fe
Author: Gaurav Kumar Garg <garg.gaurav52 at gmail.com>
Date:   Tue Oct 13 14:40:55 2015 +0530

    libglusterfs: pass buffer size to gf_store_read_and_tokenize function

    This patch is backport of: http://review.gluster.org/#/c/12346/

    Previously if user set an option where length of key=value goes beyond
    PATH_MAX (4096) character then tokenzing the option at the time of
    reading configuration file will fail.
    This is because of the we was having restraction in fgets to read maximum
    of PATH_MAX (4096) length of character.
    Consequence of this is when user try to restart glusterd, after setting
    key=value length beyond PATH_MAX (4096) character, glusterd will not
restart.

    With this fix instead of PATH_MAX, consumer of gf_store_read_and_tokenize
    function will decide the size of the buffer length.

    Cherry picked from commit 816ca94f5dd49f34f395caf501de3c71f0ba113d:
      >> Change-Id: I655a8ce982effdfff8f3e785ea31f543dbe39301
      >> BUG: 1271150
      >> Signed-off-by: Gaurav Kumar Garg <ggarg at redhat.com>
      >> Reviewed-on: http://review.gluster.org/12346
      >> Tested-by: NetBSD Build System <jenkins at build.gluster.org>
      >> Tested-by: Gluster Build System <jenkins at build.gluster.com>
      >> Reviewed-by: Anand Nekkunti <anekkunt at redhat.com>
      >> Reviewed-by: Niels de Vos <ndevos at redhat.com>

    Change-Id: I5b76e81a4ad31a286fb4298ba27f3230fba99ab4
    BUG: 1319649
    Signed-off-by: Gaurav Kumar Garg <ggarg at redhat.com>
    Reviewed-on: http://review.gluster.org/13795
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Smoke: Gluster Build System <jenkins at build.gluster.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eYSpfAOOGC&a=cc_unsubscribe